Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.x] Fix trimming direct to storage ingest #318

Merged
merged 6 commits into from
Feb 19, 2024
Merged

[1.x] Fix trimming direct to storage ingest #318

merged 6 commits into from
Feb 19, 2024

Conversation

sinnbeck
Copy link
Contributor

@sinnbeck sinnbeck commented Feb 16, 2024 •
edited
Loading

Currently pulse does not actually trim records. This is due to an accidental double clousure call in Pulse::ingest(). It uses both fn() => and $this->trim(...) causing a double closure, which is then called, resulting in trim never getting called.

//before
->winner(fn () => $this->rescue(fn () => $ingest->trim(...)))
//after
->winner(fn () => $this->rescue($ingest->trim(...)))

Reported here.
#317

@taylorotwell taylorotwell marked this pull request as draft February 16, 2024 16:10
@timacdonald timacdonald marked this pull request as ready for review February 19, 2024 04:16
@timacdonald timacdonald changed the title Fix trim in ingest [1.x] Fix trimming direct to storage ingest Feb 19, 2024
timacdonald
timacdonald approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@timacdonald timacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

Pushed up a change to DB storage tests just to make them more clear and not need to concern themselves with trimming on every test.

@taylorotwell taylorotwell merged commit ebd733a into laravel:1.x Feb 19, 2024
10 checks passed
@sinnbeck sinnbeck deleted the fix-trim branch February 19, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timacdonald timacdonald timacdonald approved these changes

@jessarcher jessarcher Awaiting requested review from jessarcher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sinnbeck @timacdonald @taylorotwell